Accept approve_policies in GitHub Pull Request Review

[matthiasr]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

• I'd be willing to implement this feature (contributing guide)

Describe the user story

Assuming a colleague opened a Terraform pull request in GitHub,
and this touches resources that require policy approval,
As a code owner and policy reviewer,
I want to give my full approval with as few steps as possible.

Describe the solution you'd like

Currently, Atlantis does not react to atlantis approve_policies when it is the message of a GitHub PR approval. After approving the code change, I have to comment the policy approval separately from the code approval.

Describe the drawbacks of your solution

This only works if I don't have anything else to say about the PR.

The policy violations that I am approving are not on the same page as the code changes. However, commonly I start by reading the PR description/comments page anyway, then check that the code matches it. In this "happy path" I have already made up my mind about the policy approval.

Describe alternatives you've considered

The status quo is not terrible, only more steps.

[matthiasr]

We didn't try this, but presumably atlantis apply also would not work. I think this request should extend to all commands for consistency.

For example, consider a team that is always pairing on changes, and that satisfies the four-eyes requirement. In this case, one pairer would submit the PR, the second could approve, apply and (if configured) merge it in one action.