Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraper is failing to handle conflicting infobox versions for the same ID on the wiki #18

Open
cdfisher opened this issue Oct 29, 2023 · 0 comments

Comments

@cdfisher
Copy link

I recently added the IDs for Awakened versions of the DT2 bosses to that section of their respective infoboxes on the wiki after getting confirmation from Jagex that the NPC IDs were shared between both versions. This resulted in there being two separate versions of each infobox tied to each of those IDs, with conflicting stats for each since they get overridden for the Awakened bosses. Both sets of stats are correct, but which is used varies situationally.

Following some support traffic in Discord that I suspected was related to my wiki edits, I looked a little closer and found that the scraper appears to have removed information relating to the relevant NPC IDs from npcs.json and npcs.min.json (See here). This removal has caused the client's Opponent Information plugin to fall back on displaying HP as a percentage for the four bosses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant