Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NodePart constructor #6

Open
ruphin opened this issue Aug 10, 2018 · 0 comments
Open

Refactor NodePart constructor #6

ruphin opened this issue Aug 10, 2018 · 0 comments

Comments

@ruphin
Copy link
Owner

ruphin commented Aug 10, 2018

With each TemplateInstance now tracking a parent and before- and after- siblings, there's some duplication going on between the TemplateInstance constructor and the NodePart constructor. The logic for determining the correct parent and context should be handled in one of these instead of both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruphin