-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove styles from slidem-slide-base #46
Comments
I originally designed the separation between Slidem-slideShould contain only things that are additional features to style text and make basic slides using HTML only. The main functionality is enabling basic layout and styling through attributes of specific child elements. It is meant to provide an "easy" way to quickly make a slide without having to touch any CSS, so a user can quickly make a deck with nothing but an HTML file. Slidem-slide-baseContains all the fundamental things that are required to make slides work. This includes slide-specific behaviours like steps. The main reason it contains some styles, is that the I consider the |
it's not that slidem's solution is bad, it's just that sometimes an author wants to bring their own. So i'm not advocating to remove the current solution, just to give authors an escape hatch in case they have special needs. |
to clarify the intent here: for regular users nothing should change they would still import deck and slide and get the same behavior that they have now. But "advanced" or "escape hatch" users would get a DOM-less experience, at least as far as slide is concerned. We should consider the possibility of providing a DOM-less base deck as well. Wherever the base class is coupled to the DOM, we can provide overridable getters, or some default configuration. |
I understand, and I think we're in agreement here. I just don't have an idea on how to facilitate this from a technical point of view, other than just exposing more internals. If you have a proposal on how to implement this change I'm happy to take a look |
Users that extend slidem-slide-base should be able to apply their own styles and DOM without having to cascade over slidem's styles.
There are different ways to accomplish content scaling than the one used in slidem-slide, so let's give users the choice by moving the constructed stylesheet from base to slidem-slide
The text was updated successfully, but these errors were encountered: