Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fate of this repo #165

Open
tcharding opened this issue Jul 16, 2024 · 6 comments
Open

The fate of this repo #165

tcharding opened this issue Jul 16, 2024 · 6 comments

Comments

@tcharding
Copy link
Member

Recently I imported (stole) all the code from this crate and put it in the new bitcoind-json-rpc repository.

There is a PR in flight at the moment to replace usage of this crate in rust-miniscript.

We also have an open issue to move the new repo into the rust-bitcoin org.

We should have a discussion about the fate of this crate. Note that in the new repo this crate is renamed so there is no reason the crate/repo cannot go on living. It seems like a waste of resources however to maintain two copies of basically the same code in the rust-bitcoin org.

FTR I already got an explicit ACK by email from RCasatta to do the import.

@tcharding
Copy link
Member Author

cc @RCasatta

@apoelstra
Copy link
Member

The fate of elementsd is similarly relevant.

FWIW I agree it's wasteful to duplicate effort. I think it'd be better if we PR'd to this repo to use the new json crate rather than bitcoin-core-rpc, since that dependency is the real reason for the fork.

@tcharding
Copy link
Member Author

I think its better not PRing to this repo because:

  • this crate and bitcoin-json-rpc-client is so tightly coupled (eg the odd use of features for Core versions)
  • the changes to use it break totally rug bitcoincore-json-rpc

Those two things are what made me import it into the other repo and rename it.

@apoelstra
Copy link
Member

Ok, yeah, that makes sense.

@RCasatta
Copy link
Collaborator

RCasatta commented Aug 5, 2024

I think we should archive this repo and point users to rust-bitcoind-json-rpc/regtest once rust-bitcoind-json-rpc has been migrated to rust-bitcoin org

@tnull
Copy link
Contributor

tnull commented Aug 30, 2024

What's the idea around electrsd after this crate now has been moved to rust-bitcoin and, IIUC, will be deprecated in favor of rust-bitcoind-json-rpc/regtest?

Will there be further work on electrsd, i.e., it will eventually update to use rust-bitcoind-json-rpc/regtest, or will it also get deprecated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants