From 84d1ad5932c7e1527a1aa1b46c1efde68a0f0244 Mon Sep 17 00:00:00 2001 From: ChrisCho-H Date: Tue, 3 Dec 2024 19:17:23 +0900 Subject: [PATCH] feat: optimize pushbytes by removing unreachable minimal check --- src/miniscript/lex.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/miniscript/lex.rs b/src/miniscript/lex.rs index 64e6bfe00..8d64fbaf5 100644 --- a/src/miniscript/lex.rs +++ b/src/miniscript/lex.rs @@ -213,14 +213,9 @@ pub fn lex(script: &'_ script::Script) -> Result>, Error> { 33 => ret.push(Token::Bytes33(bytes.as_bytes())), 65 => ret.push(Token::Bytes65(bytes.as_bytes())), _ => { + // check minimality of the number match script::read_scriptint(bytes.as_bytes()) { Ok(v) if v >= 0 => { - // check minimality of the number - if script::Builder::new().push_int(v).into_script()[1..].as_bytes() - != bytes.as_bytes() - { - return Err(Error::InvalidPush(bytes.to_owned().into())); - } ret.push(Token::Num(v as u32)); } Ok(_) => return Err(Error::InvalidPush(bytes.to_owned().into())),