Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Why is Def.sig commented out? #135

Open
jendrikw opened this issue May 9, 2018 · 1 comment
Open

Why is Def.sig commented out? #135

jendrikw opened this issue May 9, 2018 · 1 comment

Comments

@jendrikw
Copy link

jendrikw commented May 9, 2018

It is commented out since 9cf1eeb, but there is no reason given. It would be very useful to have the signature information.

Also, the structs Signature and SigElement are unused.

@nrc
Copy link
Member

nrc commented May 10, 2018

It should probably be removed along with the structs.

The story is that the signature info emitted by the compiler (https://github.com/nrc/rls-data/blob/master/src/lib.rs#L308) has changed significantly and I removed (well, commented out) support for the old signature information with the intention of adding back support for the new info. However, I haven't yet got around to that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants