New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The book does not get published properly #253

Closed

yerke opened this issue Jul 3, 2020 · 4 comments

Contributor

yerke commented Jul 3, 2020 •

edited

Loading

As pointed out by @therealprof the book is supposed to be published after merges to master branch using https://github.com/rust-embedded/discovery/blob/master/ci/after-success.sh .

Unfortunately, at least from May 2020 the book was not updated on https://docs.rust-embedded.org/discovery/ .

For example, the following 3 PRs are not reflected on the website: #179, #148 and #252 .
https://github.com/rust-embedded/discovery/tree/gh-pages gets updated, but not the website itself.

The text was updated successfully, but these errors were encountered:

Contributor Author

yerke commented Jul 3, 2020 •

edited

Loading

OK. I think I see what happens. https://docs.rust-embedded.org/discovery/ does not get updated, but https://rust-embedded.github.io/discovery/ does get correctly updated.
https://github.com/rust-embedded/docs is supposed to somehow rebuild 3 books (embedded, discovery, and embedonomicon), but does not do it in practice.

Somewhat related issue: rust-embedded/rust-embedded.github.io#23

Contributor Author

yerke commented Jul 3, 2020

This issue is a duplicate of rust-embedded/wg#457

yerke mentioned this issue

Fix broken book publishing on Travis rust-embedded/rust-embedded.github.io#24

Merged

Contributor Author

yerke commented Jul 4, 2020

@therealprof Can you please take a look rust-embedded/rust-embedded.github.io#24 ? Thanks.

bors bot added a commit to rust-embedded/rust-embedded.github.io that referenced this issue


          Merge #24

9ad8d55

24: Fix broken book publishing on Travis r=therealprof a=yerke

The books were not published on https://docs.rust-embedded.org/ since March 16 2020. Last successful build [here](https://travis-ci.org/github/rust-embedded/docs/builds/662804843), first broken build [here](https://travis-ci.org/github/rust-embedded/docs/builds/663216351). [Here](https://travis-ci.org/github/rust-embedded/docs/builds) you can see the long list of failures.

I took the changes from https://github.com/rust-embedded/discovery/blob/d42012eedb4216ae8b613c3fdfdb37f85f01656f/ci/install.sh .

For proof that the changes fix the issue see my fork in https://github.com/yerke/docs, which was successfully built with Travis in [here](https://travis-ci.com/github/yerke/docs/builds/174282136). You can see built artifacts at https://github.com/yerke/yerke.github.io/tree/gh-pages and https://yerke.github.io .

Closes #8, rust-embedded/wg#457, rust-embedded/discovery#253

Co-authored-by: Yerkebulan Tulibergenov <[email protected]>

Contributor Author

yerke commented Jul 4, 2020

Closed by rust-embedded/rust-embedded.github.io#24

yerke closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment