Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blitz more Libz! #11

Open
KodrAus opened this issue Mar 21, 2018 · 13 comments
Open

Blitz more Libz! #11

KodrAus opened this issue Mar 21, 2018 · 13 comments

Comments

@KodrAus
Copy link
Collaborator

KodrAus commented Mar 21, 2018

The libz blitz offers a great framework for exploring, evaluating and polishing libraries. Should we do more evaluations for stabilising libraries this year? If so, what libraries do folks think could benefit from a blitz?

@skade
Copy link

skade commented Mar 21, 2018

Should we do more evaluations for stabilising libraries this year?

Yes. Please note there was the wish for a better name last year.

@KodrAus
Copy link
Collaborator Author

KodrAus commented Mar 21, 2018

Please note there was the wish for a better name last year.

Ah I wasn't aware of that, and can see why some folks might prefer a different name. What if we just call them 'evaluations'?

@skade
Copy link

skade commented Mar 21, 2018

Let's bikeshed a little on that, catchy would be desirable.

@Keats
Copy link

Keats commented Mar 21, 2018

How about making https://github.com/Gilnaa/globwalk the next https://github.com/rust-lang-nursery/glob ?
That would accomplish some of rust-lang/glob#59 provided all the other issues can be fixed.

@epage
Copy link

epage commented Mar 21, 2018

As I brought up in the CLI WG, what about helping to organize libz blitz centered around each of the other WGs. For example, the CLI WG could identify features we need, crates that fulfill those features, and then work on a libz blitz to help get them fleshed out.

@Enet4
Copy link

Enet4 commented Mar 21, 2018

I would like to bring chrono to this table, although I am not entirely sure how the group can intervene. chronotope/chrono#195 Although the library is in a fairly working state right now, multiple breaking changes are desired before a stable release, and the current maintainer is lacking the time to fulfil these ideas. Considering also that there are over 500 direct dependents, diesel being one of them, it seems to me like a project worth catalysing.

@KodrAus
Copy link
Collaborator Author

KodrAus commented Mar 29, 2018

@Enet4 chrono has been on my mind for a while. @quodlibetor might have some thoughts on where/how contributions could be the most helpful.

@epage Using the domain working groups as a source for libraries to focus on sounds good to me! Particularly libraries that are common between use-cases in multiple domains. Maybe we should start a thread on one of the forums to collect a set?

@Keats Should we suggest globwalk on rust-lang/glob#59? We probably need to try revive some interest in that issue.

@skade I've opened #15 to work on a new name, so we can keep the threads a bit separate.

@quodlibetor
Copy link

Yes, I've been thinking about improving chrono's API for a long time. I've been intending to write up my plans, as well, perhaps blitzing would give me the kick I need to actually do it? It'd be welcome, anyway.

@Keats
Copy link

Keats commented Mar 29, 2018

@KodrAus the globwalk crate came from BurntSushi/ripgrep#765 so I believe we just need to improve on it first to make sure it satisfies all the requirements of the current glob crate

@quodlibetor
Copy link

Also (@KodrAus @Enet4) related to the state of chrono: one of the big issues that I had in the past was that the primary maintainer was essentially out of the picture and, although they owned the repo and crates.io, they weren't responsive or making releases. They've since transferred ownership to me, which gives me a lot more emotional wherewithal in terms of actually doing work for the project. It also means that my old philosophy of not seeking out contributions because it could be so disheartening to do work and have it not released for a year goes away.

Hopefully by this time next year we'll have a much larger group of people maintaining chrono, with at least one other releaser, and ideally a 1.0 release. There are big challenges to overcome to get there, but (other than multiple calendar systems, which I think might block 1.0 and which I don't know what they should look like) I think we can get pretty far.

@Dylan-DPC-zz
Copy link
Collaborator

@quodlibetor let me know if you need help with chrono

@quodlibetor
Copy link

Until we get an official blitz going for chrono I've written up some notes about some of the most egregious things I think need to be iterated upon: https://github.com/chronotope/chrono-rfcs/blob/master/notes/api-issues.md

I've spent a bit of time switching some types around and redesigning some traits and I think we can get to a much simpler API while still maintaining all of chrono's current power.

@KodrAus
Copy link
Collaborator Author

KodrAus commented Apr 9, 2018

@quodlibetor @Dylan-DPC @Enet4 I thought we could move the discussion about chrono into #16.

@Keats Thanks for clarifying! I think I understand the background around glob, globset and globwalk better now. It doesn't look like there's much that needs to block deprecating the current glob implementation, but I left a ping on rust-lang/glob#59 and opened #17 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants