cargo locate-project --workspace loads all the workspace

[tkr-sh]

Problem

cargo locate-project --workspace loads all the workspace instead of just returning the path of the workspace root.

Steps

cargo locate-project --workspace

Possible Solution(s)

Instead of doing

src/bin/cargo/commands/locate_project.rs

WhatToFind::Workspace => {
    workspace = args.workspace(gctx)?;
    workspace.root_manifest()
}

I think that

WhatToFind::Workspace => {
    let root = args.root_manifest(gctx)?;
    let mut ws = Workspace::new_default(root.to_path_buf(), gctx);
    ws.target_dir = gctx.target_dir()?;
    ws.find_root(manifest_path)?
}

or something like that would be better. Because when in a big workspace with a lot of members in a workspace, it will load some unused data.

[weihanglo]

Could you elaborate a bit on performance data you're looking for, and the scenario? It seems to me in a workspace of 400+ members (aws-sdk-rust) it takes ~150ms. Not ideal but it would be better to understand the use cases.

[tkr-sh]

@weihanglo I sometimes work on a workspace with ~1500 members (not open source sadly), and in this case, it takes most of the time more than a second.

[weihanglo]

arg.workspace calls Workspace::new which additionally validates the workspace. I am unsure if the proposed solution is the correct approach, as it completely skip the validation. Granted, the validation needs loading all members, which is the core of the performance issue.

[tkr-sh]

Hmmm interesting. Maybe adding a flag --no-verify would be a possible solution when performance is needed and that extra validation isn't required because the workspace is assumed to be correct ?

[epage]

imo if this command is just about locating the workspace, I think its reasonable to skip validation. Other commands will need to be run and those can do that validation.

We could punt on proper plumbing commands which would require doing the minimal work. I don't think its a big loss to this command to do it now.

[weihanglo]

This sounds pretty reasonable. I went ahead and marked this as accepted.