Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Chalk with support for well-known, builtin traits #363

Open
9 of 11 tasks
nikomatsakis opened this issue Mar 27, 2020 · 6 comments
Open
9 of 11 tasks

Extend Chalk with support for well-known, builtin traits #363

nikomatsakis opened this issue Mar 27, 2020 · 6 comments
Assignees
@basil-cow
Labels
C-chalk-solve Issues related to the chalk-solve crate

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Mar 27, 2020 •
edited by jackh726
Loading

This is a meta issue for the work of extending chalk to support the various built-in traits like Sized, Copy, and so forth.

This issue has been assigned to @Areredify via this comment.
@nikomatsakis nikomatsakis mentioned this issue Apr 1, 2020
Closed
5 tasks
@basil-cow
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this Apr 7, 2020
@detrumi detrumi assigned basil-cow and unassigned rustbot Apr 7, 2020
@nikomatsakis
Copy link
Contributor Author

I would also say that this issue is fairly 'parallelizable', so if others want to pick up some aspects of it, that's not a problem. e.g. I think we could add code for Copy and the like. Maybe it's a good idea to break those out into separate issues and write-up some mentoring instructions?

@nikomatsakis
Copy link
Contributor Author

Although they may be somewhat blocked on #371 -- having more details of Rust types would be useful.

@basil-cow
Copy link
Contributor

basil-cow commented Apr 7, 2020 •
edited
Loading

So if someone wants to pick it up, I am done with Copy, Drop and Clone (as far as I understood Clone introduces no hard coded impls and/or wf checks?) modulo #371 of course, but it will be easy to address when it comes to it. Going to pick up Unsize next

@basil-cow basil-cow mentioned this issue Apr 10, 2020
Merged
@nikomatsakis nikomatsakis mentioned this issue Apr 28, 2020
Closed
@flodiebold flodiebold mentioned this issue May 3, 2020
Closed
This was referenced May 17, 2020
Closed
Merged
Aaron1011 added a commit to Aaron1011/chalk that referenced this issue Jun 5, 2020
@Aaron1011
Add FnOnce trait, and provide impl for Function type
70dd385 
Works towards rust-lang#363

I've followed the approach taken by rustc, where `FnOnce` has single
generic argument: the tupled function parameters
(e.g. `fn(u8, bool): FnOnce<(u8, bool)>`).

I also extended the grammar to allow functions to take more than one
argument.

I've left `Fn` and `FnMut` for a separate PR - without a representation
of closures in Chalk, they are not very useful.
@Aaron1011 Aaron1011 mentioned this issue Jun 5, 2020
Merged
Aaron1011 added a commit to Aaron1011/chalk that referenced this issue Jun 5, 2020
@Aaron1011
Add FnOnce trait, and provide impl for Function type
91653d0 
Works towards rust-lang#363

I've followed the approach taken by rustc, where `FnOnce` has single
generic argument: the tupled function parameters
(e.g. `fn(u8, bool): FnOnce<(u8, bool)>`).

I also extended the grammar to allow functions to take more than one
argument.

I've left `Fn` and `FnMut` for a separate PR - without a representation
of closures in Chalk, they are not very useful.
Aaron1011 added a commit to Aaron1011/chalk that referenced this issue Jun 7, 2020
@Aaron1011
Add FnOnce trait, and provide impl for Function type
1b862b1 
Works towards rust-lang#363

I've followed the approach taken by rustc, where `FnOnce` has single
generic argument: the tupled function parameters
(e.g. `fn(u8, bool): FnOnce<(u8, bool)>`).

I also extended the grammar to allow functions to take more than one
argument.

I've left `Fn` and `FnMut` for a separate PR - without a representation
of closures in Chalk, they are not very useful.
Aaron1011 added a commit to Aaron1011/chalk that referenced this issue Jun 7, 2020
@Aaron1011
Add FnOnce trait, and provide impl for Function type
708288a 
Works towards rust-lang#363

I've followed the approach taken by rustc, where `FnOnce` has single
generic argument: the tupled function parameters
(e.g. `fn(u8, bool): FnOnce<(u8, bool)>`).

I also extended the grammar to allow functions to take more than one
argument.

I've left `Fn` and `FnMut` for a separate PR - without a representation
of closures in Chalk, they are not very useful.
nathanwhit pushed a commit to nathanwhit/chalk that referenced this issue Jun 9, 2020
@Aaron1011 @nathanwhit
Add FnOnce trait, and provide impl for Function type
c21e73e 
Works towards rust-lang#363

I've followed the approach taken by rustc, where `FnOnce` has single
generic argument: the tupled function parameters
(e.g. `fn(u8, bool): FnOnce<(u8, bool)>`).

I also extended the grammar to allow functions to take more than one
argument.

I've left `Fn` and `FnMut` for a separate PR - without a representation
of closures in Chalk, they are not very useful.
@basil-cow
Copy link
Contributor

Im already working on CoerceUnsized

@memoryleak47
Copy link
Contributor

I'll try Unpin

@memoryleak47 memoryleak47 mentioned this issue Sep 6, 2020
Merged
bors added a commit that referenced this issue Sep 9, 2020
@bors
Auto merge of #603 - memoryleak47:unpin, r=jackh726
01b4bff 
Extend well-known traits by Unpin

I read the RFC and didn't find any special rules concerning Unpin, so this one is rather straight-forward. Correct me if I missed something!
cc #363
This was referenced Oct 23, 2020
Merged
Merged
@jackh726 jackh726 added the C-chalk-solve Issues related to the chalk-solve crate label Dec 11, 2020
@basil-cow basil-cow mentioned this issue Feb 10, 2021
Merged
bors added a commit that referenced this issue Feb 11, 2021
@bors
Auto merge of #685 - Areredify:generator_movability, r=jackh726
6dd9d61 
add Movability to Generator

pretty straightforward

closes #618
cc #363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@basil-cow basil-cow

Labels
C-chalk-solve Issues related to the chalk-solve crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nikomatsakis @memoryleak47 @basil-cow @jackh726 @rustbot