Classify FIXMEs

[lvllvl]

Description

Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.

Sources

Checklist

• Relevant tests in libc-test/semver have been updated
  • Not applicable
• No placeholder or unstable values like *LAST or *MAX are
  included (see #3131)
• Tested locally (cd libc-test && cargo test --target mytarget);
  especially relevant for platforms that may not be checked in CI
  • Not applicable

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[tgross35]

Thank you, this is a great start!

Left one specific suggestion for ulibc. Could you also replace any // FIXME(...) .field(...) with // FIXME(debug): ...? I don't even know why we have debug fields labeled as FIXMEs in the first place, but we'll probably clean them all up at some point.

[tgross35]

Also please squash, I think a lot of the commits aren't relevant without the csv file.

[lvllvl]

Ok yes, I can squash and make those changes, thanks!

[tgross35]

Did the FIXME(linux) -> FIXME(ulibc) and FIXME(..) -> FIXME(debug) changes accidentally get lost in a rebase? I thought they were here at some point but I don't see them now.

[lvllvl]

Did the FIXME(linux) -> FIXME(ulibc) and FIXME(..) -> FIXME(debug) changes accidentally get lost in a rebase? I thought they were here at some point but I don't see them now.

Yes, I made that mistake with the rebase but I believe it's been resolved now.

[tgross35]

Looks good now, thanks!