Classify FIXMEs - 3

[lvllvl]

Description

Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.

Sources

Checklist

• Relevant tests in libc-test/semver have been updated
  • Not applicable
• No placeholder or unstable values like *LAST or *MAX are
  included (see #3131)
• Tested locally (cd libc-test && cargo test --target mytarget);
  especially relevant for platforms that may not be checked in CI
  • Not applicable

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Some changes occurred in OpenBSD module

cc @semarie

[tgross35]

Most look good, just a couple suggested adjustments. However, it looks like you may have picked up some unrelated changes? Probably happened with a squash, the commit says:

This is a combination of 4 commits.

[...]

# This is the commit message #3:

Declare `setdomainname` and `getdomainname` on Android.

Android [supports] `setdomainname` and `getdomainname` in API level 26.

[supports] https://github.com/aosp-google/bionic/blob/28f9101d76b709febe25977f98530d77580387d1/libc/include/unistd.h#L236

# This is the commit message #4:

Move `setdomainname` and `getdomainname` into linux_like.

[tgross35]

LGTM, could you clean up the commit history?

[rustbot]

Some changes occurred in the Android module

cc @maurer

[tgross35]

The android CI failure is probably spurious. Could you rebase onto current main to drop the merge commit?

[lvllvl]

The android CI failure is probably spurious. Could you rebase onto current main to drop the merge commit?

Ok just cleaned up the commits. Let me know if there's any other changes you'd like me to make.

[tgross35]

Thanks! I'm not sure what is going on with the Android CI but I'll try it again (leave a comment if it gets stuck again, I don't get notifications for failed jobs)