-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classify FIXMEs - 4 #4232
Classify FIXMEs - 4 #4232
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
09574d3
to
571bb88
Compare
b137822
to
ac897b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one LGTM! Style check is complaining about a line though, please just move that comment to the line above or something.
@rustbot author for the above comment |
50c2170
to
96877bf
Compare
Ok sounds good. Just made this adjustment and passed all the tests, including the style check. Lmk if any other changes are needed. |
Thanks! |
Description
Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI