Windows Git Bash Vim ALE

[coffeebe4code]

On windows I am in a git bash shell, within vim, using ALE.

I am receiving this error "url is not a file"

** edit ** sorry githubs make an issue from this line did not actually make an issue from that line.

rust-analyzer/crates/rust-analyzer/src/lsp/from_proto.rs

Line 16 in 7b4b83b

let path = url.to_file_path().map_err(|()| anyhow::format_err!("url is not a file"))?;

[lnicola]

Can you patch that to display url? But anyway, we should upgrade lsp-types, and Url has been replaced by Uri in the latest version.

CC gluon-lang/lsp-types#284, yeah, maybe we're not going to upgrade right now.

[coffeebe4code]

If I'm understanding that link. I should be able to downgrade the rust-analyzer version? Which version should I go to?

Can you patch that to display url?

This will take me some time. I'll see if I can do that sometime today.

My suspicion would be some sort of hybrid mingw path is not getting parsed correctly?

[lnicola]

If I'm understanding that link. I should be able to downgrade the rust-analyzer version?

No, I don't think this is a recent issue. The link is more about how we probably can't upgrade lsp-types right now because the new version is missing some functionality.

[coffeebe4code]

url: 'file:///c/Users/ChrisClark/type-lang/linker/src/lib.rs' is not a file

[lnicola]

Well, that's funny... At least on Linux, with url = "=2.5.2" (the version we're using):

dbg!(
    Url::parse("file:///c/Users/ChrisClark/type-lang/linker/src/lib.rs")
        .unwrap()
        .to_file_path()
);

[src/main.rs:19:5] Url::parse("file:///c/Users/ChrisClark/type-lang/linker/src/lib.rs").unwrap().to_file_path() = Ok(
    "/c/Users/ChrisClark/type-lang/linker/src/lib.rs",
)

[lnicola]

Url is a re-export in lsp-types 0.95.0: https://docs.rs/lsp-types/0.95.0/src/lsp_types/lib.rs.html#26.

[coffeebe4code]

I didn't want to spend too much time going through the URL crate. But it annoyed me very quickly.

As a file path, my path is obviously legitimate. I found a few pieces of code that had cfg! checks for windows. Which is silly to say the least. I see this a lot across lots of projects. People aren't making their libraries api's cross-platform. I may be on a linux machine, and want to validate if a windows file path is valid, and this case visa-versa.

I'm very interested in developing on Windows, and would be happy to make a change to support it. What is the shortest path that would be acceptable by the rust-analyzer team for me to do this?