Prioritize items that return an enum when requesting completion in a pattern match

[dev-ardi]

    struct S {
        field1: u32,
        field2: Option<u32>,
        field3: Result<u32, u32>,
    }
    let my_s = S {
        field1: 42,
        field2: Some(42),
        field3: Ok(42),
    };
    match my_s. // When asked for completions in this position it should prioritize fields or methods that return options.

This should generalize to matches!. This already works well for let Some() and if let Some()

[Veykril]

What is the rational behind this? One might as likely want to match on the u32 here

[dev-ardi]

I would say that by far it's not as common to match over integers as it is for enums.

[Giga-Bowser]

What about something like this?

enum A {
    Foo,
    Bar,
    Baz,
}

struct B {
    field1: A,
}

struct C {
    field1: B,
    field2: A,
}

let my_c: C = /* ... */;

match my_c. // should we suggest field1 or field2?

I would say that the "matchability" of any given field depends so much on context we really do not have that we're probably best off just trying to behave predictably