Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Rust 2024: rustfmt use version sort #123800

Open
2 of 4 tasks
traviscross opened this issue Apr 11, 2024 · 2 comments
Open
2 of 4 tasks

Tracking Issue for Rust 2024: rustfmt use version sort #123800

traviscross opened this issue Apr 11, 2024 · 2 comments
Assignees
Labels
A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. I-style-nominated Nominated for discussion during a style team meeting. S-tracking-needs-documentation Status: Needs documentation. T-style Relevant to the style team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Apr 11, 2024

This is a tracking issue for the rustfmt / T-style work needed to use version sort order in Style Edition 2024.

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

None.

Implementation history

cc @rust-lang/rustfmt @rust-lang/style @calebcartwright

@traviscross traviscross added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. A-rustfmt Area: Rustfmt T-style Relevant to the style team, which will review and decide on the PR/issue. A-edition-2024 Area: The 2024 edition I-style-nominated Nominated for discussion during a style team meeting. labels Apr 11, 2024
@joshtriplett
Copy link
Member

@calebcartwright @traviscross Verifying: this is labeled T-style and I-style-nominated, but as far as I know, this is something style already reviewed, approved, and merged into the style guide. I think this is now exclusively a matter for the rustfmt team, right?

@calebcartwright
Copy link
Member

@calebcartwright @traviscross Verifying: this is labeled T-style and I-style-nominated, but as far as I know, this is something style already reviewed, approved, and merged into the style guide. I think this is now exclusively a matter for the rustfmt team, right?

I think we answered this in a more synchronous forum like one of our t-style meetings, but for posterity, yes that's correct

matthiasgoergens added a commit to scroll-tech/ceno that referenced this issue Oct 15, 2024
Our `rust-toolchain` specifies `nightly-2024-05-02`. That one comes with
`rustfmt` version 1.7. But our `rustfmt.toml` uses `style_edition =
"2024"`; but `2024` was only added in version 1.8. So in this PR we
update to a more recent nightly toolchain.

Most of the changes in here are from our specified `rustfmt.toml` config
actually applying. The main thing that's causing a lot of diff is
[version sorting](rust-lang/rust#123800) of
imports, which changes how letter case is handled for comparison.

Fixes #297
@calebcartwright calebcartwright removed the S-tracking-impl-incomplete Status: The implementation is incomplete. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. I-style-nominated Nominated for discussion during a style team meeting. S-tracking-needs-documentation Status: Needs documentation. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants