Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: error[E0570]: "stdcall"/"fastcall" is not a supported ABI for the current target #134712

Open
cuviper opened this issue Dec 23, 2024 · 3 comments
Labels
C-bug Category: This is a bug. I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Milestone

Comments

@cuviper
Copy link
Member

cuviper commented Dec 23, 2024

  1. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/ChlorideCull.chcl_now_playing/log.txt
  2. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/PocketRelay.me3-offline-plugin/log.txt
  3. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/Sgeo.rwg_to_rwx/log.txt
  4. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/plegat.RLaminateAnalysis/log.txt
  5. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/sergemalo.sm-checkers-engine/log.txt
  6. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/weslenng-labs.visual-basic-rs/log.txt
  7. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/reg/dx_core-0.3.0/log.txt
  8. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/reg/miniblink-0.3.0/log.txt
error[E0570]: `"stdcall"` is not a supported ABI for the current target

and presumably related:

  1. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/reg/vtable_gen-1.1.0/log.txt
  2. https://crater-reports.s3.amazonaws.com/beta-1.84.0-4-retry2/beta-2024-12-08/gh/MrElectrify.vtable_gen/log.txt
error[E0570]: `"fastcall"` is not a supported ABI for the current target

Version it worked on

It most recently worked on: 1.83.0

Version with regression

Using rustc 1.84.0-beta.4 in crater #134138.

@rustbot modify labels: +regression-from-stable-to-beta -regression-untriaged

@cuviper cuviper added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Dec 23, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. and removed regression-untriaged Untriaged performance or correctness regression. labels Dec 23, 2024
@compiler-errors
Copy link
Member

This regressed in #129935.

This crater run may have missed some crates due to a recently discovered regression in crater which was reporting a large number of "unknown" results (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/crater.20returning.20unknown).

cc @RalfJung. I assume the decision shouldn't really change (I still think we should make this FCW a hard error), but perhaps we should announce to more people that their crates are gonna break.

@cuviper cuviper added this to the 1.84.0 milestone Dec 24, 2024
@cuviper
Copy link
Member Author

cuviper commented Dec 24, 2024

If you're looking for people to notify, a few more showed up in the rustdoc run:

  1. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/IDragnev.oppa/log.txt
  2. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/K0enM.sup/log.txt
  3. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/Zerx0r.rs_ppid_spoof_hollow/log.txt
  4. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/bondTM.shogi/log.txt
  5. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/chuckries.rust-com/log.txt
  6. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/den-mentiei.prima/log.txt
  7. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/dev-nolant.Rust-Command-Line-Tool/log.txt
  8. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/elipmoc.rust_dxlib/log.txt
  9. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/iamtyler.iocp.rs/log.txt
  10. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/loctranbao.ownping/log.txt
  11. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/lumenian.ping/log.txt
  12. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/shirshak55.ping/log.txt
  13. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/snf.rust_crashes/log.txt
  14. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/tspivey.tdsr-server/log.txt
  15. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/vassjozsef.nvapi-rust/log.txt
  16. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/vrnvu.pong/log.txt
  17. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/alexpilotti.libwhp-sample/log.txt
  18. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/gh/itchio.husk/log.txt
  19. https://crater-reports.s3.amazonaws.com/beta-rustdoc-1.84.0-4-retry/beta-2024-12-08/reg/webview2-0.1.4/log.txt

(edit: appended 3 more that crater hadn't IDed as E0570)

@RalfJung
Copy link
Member

RalfJung commented Dec 24, 2024

Looking at the crates.io regressions, the only new ones are

  • dx_core: hasn't been updated in 9 years
  • webview2: bindings for "Microsoft Edge WebView2 control", so anyway Windows-only

So no action necessary here. I don't usually file issues for things not on crates.io; many of those are one-off experiments and the code is clearly not meant for wider consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

4 participants