Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIR documentation is outdated #1896

Open
Arthur-Milchior opened this issue Feb 24, 2024 · 0 comments
Open

HIR documentation is outdated #1896

Arthur-Milchior opened this issue Feb 24, 2024 · 0 comments
Labels
A-HIR Area: high-level intermediate representation (HIR) E-medium Difficulty: might require some prior knowledge or code reading I-outdated Issue: info is outdated T-compiler Relevant to compiler team

Comments

@Arthur-Milchior
Copy link
Contributor

Regarding https://rustc-dev-guide.rust-lang.org/hir.html
It references the find method, which was renamed in 24f009c5e55d18c12563dd74681ca33b8a349936 into opt_hir_node which itself was deleted in a61019b29021b7635113b48e470dbac724c81c76

As far as I understand the commits I see, the assertion

Most of the time when you are working with the HIR, you will do so via the HIR Map, accessible in the tcx via tcx.hir()

became false. Those methods to navigate the HIR are now directly in Tcx. I don't know whether it's always the case or only on those examples.

I'll plainly admit I don't know enough about rustc or the HIR to know what is relevant in the documentation, so I won't create a PR myself.

@jieyouxu jieyouxu added T-compiler Relevant to compiler team E-medium Difficulty: might require some prior knowledge or code reading A-HIR Area: high-level intermediate representation (HIR) I-outdated Issue: info is outdated labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-HIR Area: high-level intermediate representation (HIR) E-medium Difficulty: might require some prior knowledge or code reading I-outdated Issue: info is outdated T-compiler Relevant to compiler team
Projects
None yet
Development

No branches or pull requests

2 participants