Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the namespace for all examples #8

Open
rib opened this issue Jun 26, 2023 · 4 comments
Open

Update the namespace for all examples #8

rib opened this issue Jun 26, 2023 · 4 comments

Comments

@rib
Copy link
Contributor

rib commented Jun 26, 2023

Currently all the examples are under a co.realfit domain-based namespace, except that the cargo apk builds will use a default package = "com.foo.bar"

We should update this to something like rust.mobile and be consistent between Gradle and cargo apk builds

@MarijnS95
Copy link
Member

And we should probably clean out all the commented cargo-apk package metadata in Cargo.toml that is currently unused, and/or switch to (or at least provide) xbuild's manifest.yaml.

@rib
Copy link
Contributor Author

rib commented Jun 26, 2023

I wonder if you could provide an example xbuild config for na-mainloop in a draft PR? I'd be happy to replace the cargo apk metadata with an xbuild config if you think that would be better?

@MarijnS95
Copy link
Member

@rib see #9, cargo-apk has a sensible default and so has xbuild.

@MarijnS95
Copy link
Member

TLDR: We can support both without providing any configuration for either 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants