Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming mean to arithmetic_mean. #66

Open
n3vu0r opened this issue May 14, 2020 · 1 comment
Open

Consider renaming mean to arithmetic_mean. #66

n3vu0r opened this issue May 14, 2020 · 1 comment

Comments

@n3vu0r
Copy link

n3vu0r commented May 14, 2020

Some functions like mean are implemented in ndarray (here) and ndarray-stats (here). When using SummaryStatisticsExt, the function mean exists two times, which is not a problem but confusing as one implementation returns Option and the other Result and it firstly seems to mismatch with the documentation.

Is it intended to have some implementations duplicated along the two crates on the long run? If so, ndarray-stats could be more specific by renaming mean to arithmetic_mean (and its axis/weighted variants) being consistent with geometric_mean and harmonic_mean. Feel free to close the issue if you prefer a simple mean.

@bluss
Copy link
Member

bluss commented Apr 6, 2021

In the long run, ndarray-stats should take over these methods from ndarray IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants