Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: tc flower support #112

Open
daniel-noland opened this issue Apr 3, 2024 · 2 comments
Open

RFC: tc flower support #112

daniel-noland opened this issue Apr 3, 2024 · 2 comments

Comments

@daniel-noland
Copy link
Contributor

I wanted to float the idea of support for tc flower filters.

flower is of special significance because some network cards (e.g. cards using the mlx5 driver or mlxsw switches) can offload significant portions of it.

I am happy to try my hand at implementing flower in this crate (and in downstream crates) but I wanted to make sure that I am on the same page with the maintainers before I implement a moderately large feature.

I have a very early code sketch in #111 which I post early to facilitate any needed discussion.

My plan is to

  • implement flower in sympathy with the pattern set down in cls_u32.rs
  • make a commit for each new key / component of filter I create

Let me know if you think I should approach this differently.

@cathay4t
Copy link
Member

I have reviewed your patch, it looks very good. Please provide unit test case like other, it also verifying you are parsing and emitting as expected. You find notes about this in top README.md

@daniel-noland
Copy link
Contributor Author

I have added a number of tests and am breaking apart the PR into tc-actions support and then tc-flower support as per discussion and to make this easier to review.

We need to make sure that this messy git commit history is fixed and #122 is merged before this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants