Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Byte Implementations #183

Open
blitz opened this issue Nov 18, 2021 · 1 comment
Open

Simplify Byte Implementations #183

blitz opened this issue Nov 18, 2021 · 1 comment

Comments

@blitz
Copy link
Contributor

blitz commented Nov 18, 2021

I'm trying to wrap my head around the different read/write functions in the Byte trait. It seems a bit needlessly intimidating and confusing. For reference, I'm refering to these functions: https://docs.rs/vm-memory/0.7.0/vm_memory/bytes/trait.Bytes.html#tymethod.read

  1. write writes to the Byte object, but write_to actually reads from it. read_into could have been a better name.
  2. Most read/write functions could have default implementations based on read/write but that seems to be prevented by the configurable error type.

Are these desirable changes?

@andreeaflorescu
Copy link
Member

I am myself a bit confused about these things, @bonzini @alexandruag @jiangliu do you have a better idea how to answer here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants