Incompatible node version possible for freshly generated project

[ro0gr]

After creating a fresh project and installing the deps:

$ npx codemod-cli new codemod-cli-test && cd codemod-cli-test/ && yarn

I get the following error:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10.13.0". Got "8.15.0"

This is caused by the fact that prettier has dropped node@8 support in v2 - https://prettier.io/blog/2020/03/21/2.0.0.html, while we still tend to node@8.

The same issue is technically possible to happen with any of

codemod-cli/commands/global/new.js

Lines 88 to 93 in 455a16b

	eslint: `^${await latestVersion('eslint')}`,
	'eslint-config-prettier': `^${await latestVersion('eslint-config-prettier')}`,
	'eslint-plugin-node': `^${await latestVersion('eslint-plugin-node')}`,
	'eslint-plugin-prettier': `^${await latestVersion('eslint-plugin-prettier')}`,
	jest: pkg.devDependencies.jest,
	prettier: `^${await latestVersion('prettier')}`,

cause we tend to install the latest versions of the deps.

In my case I've just pinned prettier to "^1.0.0" and that works. But I'm wondering if we should improve DX here? Should we:

• pin to the latest known majors
• do nothing, and leave a decision to developer, whether to remove old node versions support, or downgrade some dependency

[rwjblue]

I think the specific issue is resolved now (the last issue fixed by #94).

In my case I've just pinned prettier to "^1.0.0" and that works. But I'm wondering if we should improve DX here?

Ya, I tend to agree. Having things fail initially feels pretty bad. Let's change to use the same major that we use currently for these deps (but still grab the highest within that major).