Recognition feature flow in OnnxPrecomputedHybridSystem

[vieting]

Is anyone actively using the OnnxPrecomputedHybridSystem?

I just faced the issue that I needed to fix the merge of base feature flow and onnx fwd feature flow here

i6_experiments/common/setups/rasr/onnx_precomputed_hybrid_system.py

Line 90 in 5251dcd

flow = add_fwd_flow_to_base_flow(feature_flow, onnx_flow, fwd_input_name="onnx-fwd-input")

by removing fwd_input_name="onnx-fwd-input" and just using the default. I think the input names were changed during the PR in i6_core and I suspect I forgot to adapt it here.

[Atticus1806]

So I only tested this class once, but back then I had to change it back to fwd-input.

[vieting]

So I only tested this class once, but back then I had to change it back to fwd-input.

Which is the default value for add_fwd_flow_to_base_flow() anyway. I added the fix in #197.

[michelwi]

We had a discussion about the naming back in rwth-i6/i6_core#431 (comment)
And I thought the conclusion was that the user never has to specify anything and "it just works".

So maybe you are now wrongly specifying something here?

Willi looks in the PR

Ok, looks like it :D

[JackTemaki]

I can not really see it in my setup, but it seems somehow it.... worked in the past for me? But no idea why.