Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nn.choice default length_normalization unexpected #214

Open
albertz opened this issue Oct 5, 2022 · 0 comments
Open

nn.choice default length_normalization unexpected #214

albertz opened this issue Oct 5, 2022 · 0 comments
Assignees
@JackTemaki @mmz33

Comments

@albertz
Copy link
Member

albertz commented Oct 5, 2022

We have length_normalization=True by default. I think this is maybe unexpected.

length_normalization=False might be a better default. Or having it mandatory.

We can make it mandatory just on returnn_common side.

Otherwise, in RETURNN, this requires a new behavior version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackTemaki JackTemaki

@mmz33 mmz33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@albertz @JackTemaki @mmz33