Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlstmEncoder allow_pool_last, change default to True? #246

Open
albertz opened this issue Nov 14, 2022 · 0 comments
Open

BlstmEncoder allow_pool_last, change default to True? #246

albertz opened this issue Nov 14, 2022 · 0 comments
Milestone

Comments

@albertz
Copy link
Member

albertz commented Nov 14, 2022

It's only really relevant for small encoders, e.g. with 2 layers, which is usually when it is used as a frontend, e.g. for Conformer. Although this also might happen during pretraining of a larger BLSTM encoder.

In that case, having one pooling of size 6 is usually worse than having two pools of size 2 and 3. Or maybe it depends what comes afterwards, but this is the case when this is used as a frontend for a Conformer. So in this use case, the current default is suboptimal.

I'm not really sure what's expected.

@albertz albertz added this to the first-release milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant