Broken unit tests on Main

[golenkovm]

Hi team,

I recently updated the plugin to the latest Main version and found that uni tests cannot be initialised due to the following error:

Moodle 4.1.4+ (Build: 20230616)
Php: 7.4.33, pgsql: 14.8 (Debian 14.8-1.pgdg120+1), OS: Linux 5.15.0-1023-aws x86_64

Warning: require_once(/var/www/site/mod/pdfannotator/tests/privacy/../fixtures/test_indicator_max.php): failed to open stream: No such file or directory in /var/www/site/mod/pdfannotator/tests/privacy/provider_test.php on line 27

This seems to be a regression of dcb9c86

[golenkovm]

I tried to implement a patch for this issue, please see golenkovm@84e58d7 but was facing more and more issues.

I gave up on the following failure as it looks like privacy provider and/or phpunit setup do not work as expected. It would be good if someone who implemented them took a look and fixed them

root@192a3db3c939:/var/www/site# vendor/bin/phpunit --testsuite='mod_pdfannotator_testsuite'
Moodle 4.1.4+ (Build: 20230629), 3d328eeb123c8d89e24e6ee208ac8aac0a621ee5
Php: 8.0.29, mysqli: 8.0.33, OS: Linux 5.19.0-43-generic x86_64
PHPUnit 9.5.27 by Sebastian Bergmann and contributors.

F                                                                   1 / 1 (100%)

Time: 00:30.179, Memory: 80.50 MB

There was 1 failure:

1) mod_pdfannotator\privacy\provider_test::test_delete_data_for_users
Failed asserting that actual size 0 matches expected size 1.

/var/www/site/mod/pdfannotator/tests/privacy/provider_test.php:128
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80

FAILURES!
Tests: 1, Assertions: 1, Failures: 1.

[golenkovm]

Spent some more time to implement the patch. However, it still feels like the unit test doesn't really test things properly so feel free to re-write/amend the patch