Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Spam on Paper server: A structure is trying to spawn without the plugin initialization step being completed. #157

Open
BigScary opened this issue Dec 15, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@BigScary
Copy link

Describe the bug
Hey I'm running a very recent official paper 1.19.3 build. This is absolutely spamming my logs, had to uninstall the plugin for now.

A structure is trying to spawn without the plugin initialization step being completed.
If you are using a fork of Spigot, this likely means that the fork does not adhere to the API standard properly.

May I humbly suggest rather than:

if(not initialized) error message

prefer:

if(not initialized) initialize

Not being a smartass. Possibly a reliable design workaround in case the boot sequence varies a little across forks or in the future of Spigot. <3 Love this plugin, my players are super excited about the possibility of our server having it (again, after some time away).

@BigScary BigScary added the bug Something isn't working label Dec 15, 2022
@ryandw11
Copy link
Owner

This is a tricky issue since the plugin needs to have some of its initialization process after all the plugins load. Unfortunately, there is no API for me to determine this, so I have to use a somewhat hacky method (although it works well on Bukkit/Spigot).

Does the plugin ever initialize or does it stay uninitialized even after the server finishes loading?
You can tell if you see

[CustomStructures] The plugin has been fully enabled with x structures.

I've never been able to reproduce this issue with an installation of paper before.

@ryandw11 ryandw11 self-assigned this Dec 17, 2022
@BigScary
Copy link
Author

BigScary commented Dec 21, 2022

Attaching two complete logs (together they cover a 24 hour period), please treat with care as they naturally include some player chat and whispers. <3

[Removed]

Didn't see any instance of "The plugin has been fully enabled" when I searched.

This might be relevant? Likely cause: I had the plugin disabled for many months due to performance issues. I have re-enabled it in hopes they have been since fixed, or other perf improvements on my server have given us enough headroom to absorb the burden.

[09:05:58] [Server thread/INFO]: ===============[CUSTOM STRUCTURES UPDATE]===============
[09:05:58] [Server thread/ERROR]: [CustomStructures] Unable to update plugin! Backup data is outdated!
[09:05:58] [Server thread/ERROR]: [CustomStructures] Please delete the backup folder in the CustomStructures directory before continuing!
[09:05:58] [Server thread/INFO]: ===============[CUSTOM STRUCTURES UPDATE]===============

@ryandw11
Copy link
Owner

To fix that just delete the backup folder in the CustomStructures plugin folder.

@Whitescan
Copy link

This issue occures on Purpur (... Spigot -> Paper -> Pufferfish -> Purpur) build 1894 (1.19.3)

@BigScary
Copy link
Author

Just confirming deleting the backup folder fixed this issue, at least for my case.

@giopalma
Copy link

Problem is not solved. I have this problem in Paper 1.19.3
The backup folder is not present in CustomStructures folder
The plugin spams the messages

If you are using a fork of Spigot, this likely means that the fork does not adhere to the API standard properly.
A structure is trying to spawn without the plugin initialization step being completed.

But after it says

[CustomStructures] Loading structures from files.
[CustomStructures] The plugin has been fully enabled with 1 structures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants