fix: bad age.identityPaths default value on darwin, bump to macOS-latest in CI #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codgician
force-pushed
the
fix-darwin-module
branch
2 times, most recently
from
d5e66fb to
ac1dd99
Compare
codgician
force-pushed
the
fix-darwin-module
branch
from
ac1dd99 to
aeb2392
Compare
codgician
changed the title
codgician
changed the title
codgician
force-pushed
the
fix-darwin-module
branch
from
aeb2392 to
302ab0c
Compare
|
Thanks for working on this!
Personally I would recommend against this. I don't see any in-progress work towards adding this, if it never manifests then we've made the code a little more confusing and complex without good reason. A few other thoughts incoming! |
n8henrie
requested changes
Jan 12, 2025
|
Thank you @n8henrie for the insights. It make sense to simplify the logic if |
codgician
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LnL7/nix-darwin#1172,
services.openssh.enableis introduced for Darwin with default value beingnullinstead of a boolean.services.openssh.hostKeysis still not available on Darwin.The default value of
age.IdentityPathsassumesservices.openssh.enablebeing a boolean, causing evaluation failure on Darwin if not explicitly defined.This PR attempts to:
services.openssh.hostKeyscould be picked up for Darwin if it is implemented in the future.macOS-12tomacOS-15in CI because it is deprecated by GitHub.