Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CacheControl params #98

Open
Jsbbvk opened this issue Oct 20, 2022 · 1 comment
Open

Extend CacheControl params #98

Jsbbvk opened this issue Oct 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Jsbbvk
Copy link

Jsbbvk commented Oct 20, 2022

Is it possible to make the CacheControl option configurable? I would like for a file to overwrite an already existing file in S3, but CacheControl prevents the url from displaying the latest file.

@ryanto
Copy link
Owner

ryanto commented Oct 21, 2022

Hey there, and thanks for opening the issue!

Currently it's not possible to change the cache control headers. One thing you can do is upload a new file, and start serving that new file instead of overwriting an existing file.

If that won't work for you and you need to overwrite the existing file I'd be happy to accept a PR that allows you to configure cache control headers. If you interested in creating that PR, why don't you first propose what you think the API should look like for setting cache control headers and we can iron that out before you write any code.

Again thanks for the issue!

@ryanto ryanto added the enhancement New feature or request label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants