Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: mb-* override by timeline-compact when used with timeline-start but not timeline-end #3224

Open
HarryHung opened this issue Oct 3, 2024 · 3 comments
Labels

Comments

@HarryHung
Copy link

What version of daisyUI are you using?

v4.12.10

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/90vptzttvW

Describe your issue

I notice that when a timeline is built with timeline-compact class, mb-10 or any bottom margin class is overriden in items with timeline-start class, but not those with timeline-end class, making the separation between items inconsistency.

This behaviour is observable in DaisyUI own example when it switch to a compact timeline: https://daisyui.com/components/timeline/#timeline-with-icon-snapped-to-the-start

My own React module built based on the example code also have the same issue, it could be workaround by marking mb-* class as important (e.g. !mb-10)

Copy link

github-actions bot commented Oct 3, 2024

Thank you @HarryHung for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@saadeghi
Copy link
Owner

saadeghi commented Oct 9, 2024

Will be fixed in daisyUI 5.
Until then you can use pb-10 instead. (or !mb-10)

@HarryHung
Copy link
Author

Thank you for the info and your effort. I am looking forward to v5.

@saadeghi saadeghi added the v5 label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants