Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the similarity transform implementation support reflection? #164

Open
tischi opened this issue Dec 9, 2023 · 3 comments
Open

Does the similarity transform implementation support reflection? #164

tischi opened this issue Dec 9, 2023 · 3 comments

Comments

@tischi
Copy link

tischi commented Dec 9, 2023

From Wikipedia: https://en.wikipedia.org/wiki/Similarity_(geometry)

In Euclidean geometry, two objects are similar if they have the same shape, or if one has the same shape as the mirror image of the other. More precisely, one can be obtained from the other by uniformly scaling (enlarging or reducing), possibly with additional translation, rotation and reflection.

In my hands it seemed as if reflection is not part of the current implementation, is it?

@bogovicj
Copy link
Contributor

You're right that reflection is not included.

Bigwarp estimates the similarity (and linear transforms) using
https://github.com/axtimwalde/mpicbg/blob/cbbe21d78fef3c40a5da50f3bdb8da68b5c14b51/mpicbg/src/main/java/mpicbg/models/SimilarityModel3D.java

@tischi
Copy link
Author

tischi commented Dec 12, 2023

All right, I guess changing this to include reflection is out of scope?

Would it be possible to add a new class SimilarityWithReflectionModel3D?

I think we will be quite often having the use-case where we would need reflection but not full affine.

As a workaround, I have implemented in MoBIE a manual transformation just for reflections; so we are not totally stuck.

@bogovicj
Copy link
Contributor

Adding something like that would be nice. Maybe the time is now to move those things from the mpicbg repo to imglib2-realtransform (?)

Will discuss with @axtimwalde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants