From f62cfdd6a4febd30b267cc72054c92fe9a1444bf Mon Sep 17 00:00:00 2001 From: John Bogovic Date: Tue, 4 Jun 2024 13:33:15 -0400 Subject: [PATCH] style: AmazonS3UtilsTest --- .../saalfeldlab/n5/s3/AmazonS3UtilsTest.java | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/test/java/org/janelia/saalfeldlab/n5/s3/AmazonS3UtilsTest.java b/src/test/java/org/janelia/saalfeldlab/n5/s3/AmazonS3UtilsTest.java index 0c20d95..63e278c 100644 --- a/src/test/java/org/janelia/saalfeldlab/n5/s3/AmazonS3UtilsTest.java +++ b/src/test/java/org/janelia/saalfeldlab/n5/s3/AmazonS3UtilsTest.java @@ -8,7 +8,6 @@ import java.util.HashMap; import java.util.Map; -import com.google.common.collect.Maps; import org.junit.Test; public class AmazonS3UtilsTest { @@ -17,26 +16,26 @@ public class AmazonS3UtilsTest { public void testUriParsing() throws URISyntaxException { // dummy client - String[] prefixes = new String[]{ + final String[] prefixes = new String[]{ "s3://", "https://s3-eu-west-1.amazonaws.com/", "http://localhost:8001/", }; - String[] buckets = new String[]{ + final String[] buckets = new String[]{ "zarr-n5-demo", "static.wk.org"}; - String[] paths = new String[]{ + final String[] paths = new String[]{ "", "foo.zarr", "data/sample"}; - for (String prefix : prefixes) - for (String bucket : buckets) - for (String path : paths) { - String uriString = prefix + bucket + "/" + path; - URI uri = new URI(uriString); + for (final String prefix : prefixes) + for (final String bucket : buckets) + for (final String path : paths) { + final String uriString = prefix + bucket + "/" + path; + final URI uri = new URI(uriString); assertEquals("bucket from uri", bucket, AmazonS3Utils.getS3Bucket(uri)); assertEquals("key from uri", path, AmazonS3Utils.getS3Key(uri)); AmazonS3Utils.createS3(uriString); @@ -87,9 +86,9 @@ public void getS3InfoTest() { keyToTests.put("a", onePartKeyNoSlashTests); keyToTests.put("a/b/c/d", multiPartKeyNoSlashTests); - for (Map.Entry tests : keyToTests.entrySet()) { + for (final Map.Entry tests : keyToTests.entrySet()) { final String expectedKey = tests.getKey(); - for (String uri : tests.getValue()) { + for (final String uri : tests.getValue()) { assertEquals(bucketName, AmazonS3Utils.getS3Bucket(uri)); assertEquals("Unexpected key for " + uri, expectedKey, AmazonS3Utils.getS3Key(uri)); }