Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix java version in install script #32

Open
tischi opened this issue Jan 25, 2023 · 2 comments
Open

fix java version in install script #32

tischi opened this issue Jan 25, 2023 · 2 comments

Comments

@tischi
Copy link

tischi commented Jan 25, 2023

@axtimwalde @mkitti

In this script: https://github.com/saalfeldlab/n5-utils/blob/master/install

Is there a way to fix the java version in a way that would work both on a Mac and on Linux?

I have the issue that I need to run such installations scripts on computers that have multiple JDK installed....

@mkitti
Copy link
Contributor

mkitti commented Jan 25, 2023

I'm unclear what you mean by "fix". Do you want to set it to be a constant value? Or is this broken on Mac or Linux?

I think the java selected could be influenced by the PATH environment variable and/or symlinks. Perhaps the other way would be to look for the JAVA_HOME environment variable.

Also cc: @bogovicj

@tischi
Copy link
Author

tischi commented Jan 26, 2023

Do you want to set it to be a constant value?

Yes, because some SciJava things don't yet run with Java > 8

Ah and there is another issue with UseConcMarkSweepGC, but I see you have solved it already:

if [[ $(java -version 2>&1 | grep version) =~ 1.8 ]]
	then
		echo '  -XX:+UseConcMarkSweepGC \' >> n5-view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants