Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefund Verification Script Overflow #586

Open
nlordell opened this issue Jul 18, 2024 · 3 comments
Open

Prefund Verification Script Overflow #586

nlordell opened this issue Jul 18, 2024 · 3 comments

Comments

@nlordell
Copy link
Collaborator

The prefund verification script can overflow, and cause the GitHub action to not correctly mark a chain as ready to deploy (source):

Run bash ./.github/scripts/validate_new_chain_request.sh
Extracted RPC url: https://jsonrpc.euphoria.aura.network./ Trying to get the chain id...
6321 from the RPC URL is valid. Checking the chain in chainlist...
Current gas price: 0x7
Estimated deployment gas limit: 0x13f5d
Expected pre-fund: 858445
Deployer address balance: -8446744073709551616
Error: Process completed with exit code 1.
@mmv08
Copy link
Member

mmv08 commented Jul 18, 2024

I guess it might be time to rewrite that to JavaScript

@nlordell
Copy link
Collaborator Author

I was thinking the exact same thing!

@Hecate2
Copy link

Hecate2 commented Jul 19, 2024

Evil workaround: I sent 10^19 gwei and met overflowed minus balance -8446744073709551616 . Yet I sent another 8.5 * 10^18 gwei to let it overflow again, back to positive balance🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants