Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate if we should update primus #2551

Closed
haraldschilly opened this issue Dec 6, 2017 · 2 comments
Closed

investigate if we should update primus #2551

haraldschilly opened this issue Dec 6, 2017 · 2 comments
Labels
A-hub A-upgrade

Comments

@haraldschilly
Copy link
Contributor

I've noticed that our primus is a bit old. Maybe we should update it to fix some connection issues?

This branch is my first step towards that: https://github.com/sagemathinc/cocalc/tree/primus7

With that, the dev-version works, but it seems like "ping" isn't doing anything? The API still has the same events, though.
@williamstein
Copy link
Contributor

A good reason now is that upgrading should work around Safari too aggressively throttling websockets...

See socketio/socket.io#2924 (comment) and primus/primus#534

@williamstein
Copy link
Contributor

Instead of upgrading, we will switch from Primus to NATS: #8118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-hub A-upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haraldschilly @williamstein