Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: View --> Guide doesn't show the guide when the terminal is not the main file type #8204

Open
williamstein opened this issue Feb 21, 2025 · 1 comment

Comments

@williamstein
Copy link
Contributor

  1. Open a file foo.py
  2. Split the frame and make one frame a terminal
  3. Select View --> Guide
  4. The guide frame does not appear

The above works fine if the file is foo.term.

The problem is that the guide is a different type of frame that isn't configured at all for .py files (say).

How to fix:

  • bad hack: in every place where we add "terminal" as an allowed frame type when registering an editor, also add the guide frame type. This is bad since it is confusing and clutters the UI.
  • better hack: somehow just allow this guide to be opened anyways if terminal is there, but don't list it explicitly in any menus.
@williamstein
Copy link
Contributor Author

Regarding fault: this bug was introduced by me when switching to the "new" frame system a long time ago...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant