Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework signal handling #477

Closed
saghul opened this issue Apr 9, 2024 · 1 comment
Closed

Rework signal handling #477

saghul opened this issue Apr 9, 2024 · 1 comment

Comments

@saghul
Copy link
Owner

saghul commented Apr 9, 2024

  • Add some addSignalListener / removeSignalListener a la Deno
  • Ignore SIGPIPE
  • Don't expose signal handling APIs to workers
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: refactor signal handling
184ecdd 
Replace the current signal API with one following a similar model to
EventTarget, a la Deno.

Before

```
const sh = tjs.signal('SIGINT', handleSigInt);
// sh needs to be alive or the signal handler is destroyed.
```

After

```
tjs.addSignalListener('SIGINT', handleSigInt);
// No need to use a handle, it can be removed with
// tjs.removeSignalListener.
```

Fixes: #476
Ref: #477
@saghul saghul mentioned this issue Apr 9, 2024
Merged
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: refactor signal handling
2ea9fc3 
Replace the current signal API with one following a similar model to
EventTarget, a la Deno.

Before

```
const sh = tjs.signal('SIGINT', handleSigInt);
// sh needs to be alive or the signal handler is destroyed.
```

After

```
tjs.addSignalListener('SIGINT', handleSigInt);
// No need to use a handle, it can be removed with
// tjs.removeSignalListener.
```

Fixes: #476
Ref: #477
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: ignore SIGPIPE
6ac9f33 
Ref: #477
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: don't expose signals functionality in workers
e105358 
Ref: #477
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: refactor signal handling
f36a80b 
Replace the current signal API with one following a similar model to
EventTarget, a la Deno.

Before

```
const sh = tjs.signal('SIGINT', handleSigInt);
// sh needs to be alive or the signal handler is destroyed.
```

After

```
tjs.addSignalListener('SIGINT', handleSigInt);
// No need to use a handle, it can be removed with
// tjs.removeSignalListener.
```

Fixes: #476
Ref: #477
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: ignore SIGPIPE
110f21a 
Ref: #477
saghul added a commit that referenced this issue Apr 9, 2024
@saghul
core: don't expose signals functionality in workers
74c1d91 
Ref: #477
@saghul
Copy link
Owner Author

saghul commented Apr 9, 2024

Done in #480

@saghul saghul closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saghul