Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/asm/hal considered harmful #331

Open
GoogleCodeExporter opened this issue Nov 21, 2015 · 3 comments
Open

include/asm/hal considered harmful #331

GoogleCodeExporter opened this issue Nov 21, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Go through src/arch/${ARCH}/include/asm/hal
2. Look into few header there
3. You will probably see something like:
    #ifndef HAL_XXX_H_
    # error "Do not include this file directly!"
    #endif /* HAL_XXX_H_ */

It is better to place and name such implementation headers near the 
corresponding sources and include them using __module_headers(...)

Original issue reported on code.google.com by Eldar.Abusalimov on 28 Aug 2011 at 12:05

@GoogleCodeExporter
Copy link
Author

Move to background

Original comment by Eldar.Abusalimov on 19 Oct 2011 at 9:59

  • Changed state: Accepted
  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Original comment by Eldar.Abusalimov on 15 Aug 2012 at 2:07

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by Eldar.Abusalimov on 18 Jan 2013 at 10:38

  • Changed state: Accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant