From d77c0efbb5e37497839196b5c7b16cfc3a4e429f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20R=C3=BCger?= Date: Sun, 27 Aug 2023 12:22:59 +0200 Subject: [PATCH 1/3] fix #256 by importing `.js` file and therefore removing the trailing slash --- lib/cookie.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cookie.js b/lib/cookie.js index f90d6a71..a3f8841c 100644 --- a/lib/cookie.js +++ b/lib/cookie.js @@ -29,7 +29,7 @@ * POSSIBILITY OF SUCH DAMAGE. */ "use strict"; -const punycode = require("punycode/"); +const punycode = require("punycode/punycode.js"); const urlParse = require("url-parse"); const pubsuffix = require("./pubsuffix-psl"); const Store = require("./store").Store; From 1ea52ac48efe43810100cf68494048414e7da00a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20R=C3=BCger?= Date: Thu, 18 Jan 2024 20:53:08 +0100 Subject: [PATCH 2/3] fix: patch the new version --- lib/cookie/canonicalDomain.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cookie/canonicalDomain.ts b/lib/cookie/canonicalDomain.ts index 1db890d5..6029ed8d 100644 --- a/lib/cookie/canonicalDomain.ts +++ b/lib/cookie/canonicalDomain.ts @@ -1,4 +1,4 @@ -import * as punycode from 'punycode/' +import * as punycode from 'punycode/punycode.js' import { IP_V6_REGEX_OBJECT } from './constants' // S5.1.2 Canonicalized Host Names From 502600ca7c8682c75fa85771aafdd2ee830d9c53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hannes=20R=C3=BCger?= Date: Mon, 12 Feb 2024 21:25:05 +0100 Subject: [PATCH 3/3] chore: update @types/punycode --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3695d656..03906480 100644 --- a/package-lock.json +++ b/package-lock.json @@ -17,7 +17,7 @@ "@types/jest": "^29.5.10", "@types/node": "^14.18.63", "@types/psl": "^1.1.3", - "@types/punycode": "^2.1.3", + "@types/punycode": "^2.1.4", "@types/url-parse": "^1.4.11", "@typescript-eslint/eslint-plugin": "^6.13.1", "@typescript-eslint/parser": "^6.13.1", @@ -1711,9 +1711,9 @@ "dev": true }, "node_modules/@types/punycode": { - "version": "2.1.3", - "resolved": "https://registry.npmjs.org/@types/punycode/-/punycode-2.1.3.tgz", - "integrity": "sha512-dFkH9Mz0yY5UfQVSrpj1grQyqRwe4TohTLlHFx4Gli8/fsaNyoOVUAsiEBZk5JBwbEJVZ49W6st8D5g6dRJb/w==", + "version": "2.1.4", + "resolved": "https://registry.npmjs.org/@types/punycode/-/punycode-2.1.4.tgz", + "integrity": "sha512-trzh6NzBnq8yw5e35f8xe8VTYjqM3NE7bohBtvDVf/dtUer3zYTLK1Ka3DG3p7bdtoaOHZucma6FfVKlQ134pQ==", "dev": true }, "node_modules/@types/semver": { @@ -8198,9 +8198,9 @@ "dev": true }, "@types/punycode": { - "version": "2.1.3", - "resolved": "https://registry.npmjs.org/@types/punycode/-/punycode-2.1.3.tgz", - "integrity": "sha512-dFkH9Mz0yY5UfQVSrpj1grQyqRwe4TohTLlHFx4Gli8/fsaNyoOVUAsiEBZk5JBwbEJVZ49W6st8D5g6dRJb/w==", + "version": "2.1.4", + "resolved": "https://registry.npmjs.org/@types/punycode/-/punycode-2.1.4.tgz", + "integrity": "sha512-trzh6NzBnq8yw5e35f8xe8VTYjqM3NE7bohBtvDVf/dtUer3zYTLK1Ka3DG3p7bdtoaOHZucma6FfVKlQ134pQ==", "dev": true }, "@types/semver": { diff --git a/package.json b/package.json index 74be9da4..3e59bafc 100644 --- a/package.json +++ b/package.json @@ -102,7 +102,7 @@ "@types/jest": "^29.5.10", "@types/node": "^14.18.63", "@types/psl": "^1.1.3", - "@types/punycode": "^2.1.3", + "@types/punycode": "^2.1.4", "@types/url-parse": "^1.4.11", "@typescript-eslint/eslint-plugin": "^6.13.1", "@typescript-eslint/parser": "^6.13.1",