Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this prevent job queuing? #46

Open
rsanheim opened this issue Jun 30, 2022 · 3 comments
Open

Does this prevent job queuing? #46

rsanheim opened this issue Jun 30, 2022 · 3 comments

Comments

@rsanheim
Copy link

Heya cool project! Quick question - I see from the README:

allowing read-only external connections (disables job queueing, non-GET requests, etc.)

However, I'm not seeing anything that would prevent jobs getting enqueued via ActiveJob or Sidekiq or whatever. Am I missing the hook or code that would prevent that from happening?

We currently enforce a sandbox for our prod console via some scripting, but there is nothing preventing someone from accidentally kicking off some model method that enqueues a job that ends up modifying data off in a different process. I know there are various hooks and things that we could use in ActiveJob or Sidekiq, but came here looking to see if there are some nice established patterns to use 😁 .

@jturkel
Copy link
Member

jturkel commented Jul 5, 2022

Apologies @rsanheim but this gem currently only supports sandboxing for Postgres connections. #1 and #22 are tracking generalizing this but we don't have any immediate plans to work on these issues (but contributions are always welcome). I'll fix the README to accurately reflect this.

@jturkel
Copy link
Member

jturkel commented Jul 5, 2022

README updated in 0cdaeea.

@mileszim
Copy link

mileszim commented Dec 2, 2022

#50 handles this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants