Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous parse on from from rust #400

Closed
nishanthkarthik opened this issue Feb 9, 2025 · 3 comments
Closed

Ambiguous parse on from from rust #400

nishanthkarthik opened this issue Feb 9, 2025 · 3 comments

Comments

@nishanthkarthik
Copy link

@insert_edge(graph : ptr<int>, from : int, to : int, size: int) {

The Rust Bril parser fails on encountering from. I think that's because from is defined as a keyword in https://github.com/sampsyo/bril/blob/main/bril-rs/bril2json/src/bril_grammar.lalrpop#L25.

I'm not sure if bril-txt supports imports because I don't see it in the grammar.

Fixing the example is the easiest workaround. Should I fix the rust grammar instead?

@Pat-Lafon
Copy link
Contributor

Thanks for the report. I have a patch in flight(9781df5) which I expect will get merged in with #398

@Pat-Lafon
Copy link
Contributor

This should be resolved now.

@sampsyo
Copy link
Owner

sampsyo commented Feb 11, 2025

Ah right, good point!

@sampsyo sampsyo closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants