Map based_near in from_resource #6926
Labels
Comments
laritakr
added a commit
that referenced
this issue
Oct 16, 2024
This may still be needed, but this doesn't work correctly. A ticket has been created for this bug if this is something that is ever needed. #6926
orangewolf
added a commit
that referenced
this issue
Oct 16, 2024
* Add failing specs to fix * Maps location for wings migrations - Native Valkyrie objects contain a URI string, not an RDF::URI - Fedora contains Hyrax::ControlledVocabularies::Location objects Modifies the behavior of the `based_near` attribute in the `to_resource` and `from_resource` methods. When using wings to convert between resources & fedora works, we were previously storing the RDF::URI in Valkyrie. This PR updates the behavior to consistently return values consistent with what would be seen in native objects. * Pacify the cops * Undo Active Fedora conversion of based_near This may still be needed, but this doesn't work correctly. A ticket has been created for this bug if this is something that is ever needed. #6926 --------- Co-authored-by: Rob Kaufman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Descriptive summary
Related to #6922
The above pull request fixed based_near for to_resource. However, the attempt to migrate from a valkyrie resource back to a fedora object and save in Fedora did not work.
Based_near in Fedora should be saved as a location object, so the migration from a valkyrie resource should handle this behavior (if anyone actually ever needs to do this).
The text was updated successfully, but these errors were encountered: