input-parameter check for setYRange() #33
Comments
Initial solution towards issue #33 - still todo is to detect spectra with all very small counts, and automatically adjust y-range (current app logic expects roughly 1 count per channel as smallest non-zero y-values - roughly)
|
Hello Dr @furutaka, Sorry, it took me a little while to get around to this! I just pushed a partial fix to this in commit 95272d4. Now calling 
Are you able to build the code yourself, or would you like me to create a version of the app with this fix? Linux, right? sincerely, |
|
Dear Dr. Johnson, Thanks for the fix! Yours, |
|
The automated "bleeding edge" Windows build at https://github.com/sandialabs/InterSpec/releases/tag/bleeding-edge should have picked up these changes, and I'll try to find some time to make a Linux build soon. |
|
I added a Linux release to https://github.com/sandialabs/InterSpec/releases/tag/v1.0.13_rc2 . For what its worth, if you can use Docker, or similar, the instructions at: Btw, I would expect things like peak fitting to totally fail for these small amplitude spectra. Hopefully I'll get to improving the display more sometime soon. happy Sports Day! |
|
Dear Dr. Johnson, Thanks for the linux binary! I'll try it. I suddenly made up my mind to try to build a linux binary also by myself at home, as a holiday project (it's a Japanese national holiday). Yours, |
|
There are some instructions for building the pre-requisites, including these libraries, for Linux at: https://github.com/sandialabs/InterSpec/tree/master/target/patches#building-dependencies-on-linux However, if you specify Hope you make it outside to enjoy the holiday!!! best luck, and please accept my apologies for the build process being a bit rough, |
|
I tried to build v1.0.13_rc2 on my linux box at home (Fedora 40 (x86_64)):
The last command stopped with:
although an rpm package named It seems to me that Eigen3 is a template library and there's no need to link its compiled library, and I've modified the CMakeLists.txt for InterSpec: Then, another cmake command finished with a warning which I've ignored because it seems to be in Wt, Finally, the make stopped with the following error: I'll try to build individual dependencies later... Kazuyoshi |
|
Compiling other peoples C++ is the worst :p Hmmm, it looks like CMake is finding HARU PDF that is installed through your package manager, which is causing Wt to compile with PDF support - but then maybe the system HARU is older or newer than Wt expects/needs. You could try setting the CMake variable It looks like I could probably either set all the un-needed Wt option/libraries/features to off, around line 88 of cmake/FetchInterSpecDeps.txt (e.g., add I'm sorry you've hit this Dr @furutaka ! |
|
Continued trying to build the v1.0.13_rc2 at work. After cmake'ing with the following command, the make stopped at about 80% with the following message: So I've also modified the After that, the make seemed to be finishing but stopped at the final linking step... Is it due to some misconfiguration of CMake? By the way, I also used the provided binaries (Win & Linux) and tried to change ordinate scale, but couldn't do it: sometimes it says "Setting to count range [A, B] not fully be fulfilled" and nothing is displayed, and sometimes "Now setting count range to [C, D] counts" but the scale is not changed... (animated gif attached). I'm afraid the commands issued might be wrong... What does it mean by "... not fully be fulfilled"? Kazuyoshi |
|
Getting closer! Are you pointing CMake to the top-level InterSpec code directory, or to i.e., the build commands should be similar to: And if all was successful the built app should be in As for the |
|
Dear Dr. Johnson, Thanks for the procedure... Well, more than 2 years have passed and I'm not yet accustomed to using JavaScript and CMake... As for the spectrum, I've emailed one! Kazuyoshi |
|
Thanks for the spectrum! I think you do need to run all the commands from the previous post in the This did inspire me to start the 'feature/LinuxCiBuild' branch, which is a work-in-progress, to add an automated Linux build for code pushes. Its currently building the app, but there is still a little ways to go for updating the bleeding edge release with the results. |
|
Btw, you can replace SpectrumChartD3.js in a older version of InterSpec to get better display these small amplitude spectra. The fix to |
|
Hi,
It seems that a related(?) file, SpectrumChartD3StandAlone.css, has already been removed in commit c9ea44e, and cause the installation failure at the final stage. In addition, according to this article, recent standard c++ library does not have So I did the following modification. With the above modification as well as manual preparation of boost_1_78_0 and the patched Wt-3.7.1, I finally succeeded in building an electron-app InterSpec (commit a8bd58b) on a linux box (Fedora 40):
Wt was compiled with The only remaining issue in building is the use of cmake-js through proxy/firewall at work... Yours, |
Hi!
I'd like to use the great power of InterSpec to analyze the results of particle-transport simulation such as PHITS. The output data were read after converted to SPC format. I choose the unit "number-of-gamma-detection-in-a-Ge-detector/number-of-primary-particle" for the output data, and the values tend to be very small (e.g., ~1/millons).
When I read such a spectrum with InterSpec and try to change the ordinate scale using setYRange() by, say,
setRange(1e-9,1e-4), I got yelled at, as the difference between the named upper/lower boundaries are less than 0.01 (insrc/TerminalModel.cpp).Would it be possible to check the validity of the input parameters without using an absolute value of the difference such as "0.01"(for example, upperBound should be larger than 1.01*lowerBound)?
For the time being, the spectra are scaled by, say, 109.
Thanks in advance,
Kazuyoshi
The text was updated successfully, but these errors were encountered: