Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stream mixing functions support non-hydrocarbon chemistry #36

Open
michael-a-hansen opened this issue Jun 7, 2024 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@michael-a-hansen
Copy link
Collaborator

Things like mix_for_equivalence_ratio use Cantera and can only do hydrocarbon chemistry, even though we generalized our direct stoichiometry calculations to include Aluminum. We just need to not use Cantera everywhere for this.

Since we support non-hydrocarbon elsewhere I'm labeling this as a bug. The methods produce the wrong results (pure fuel) and don't indicate so.

@michael-a-hansen michael-a-hansen added bug Something isn't working enhancement New feature or request labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant