Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS review] Remove external licenses in NOTICE folder #63

Closed
AdamRJensen opened this issue Sep 12, 2023 · 2 comments
Closed

[JOSS review] Remove external licenses in NOTICE folder #63

AdamRJensen opened this issue Sep 12, 2023 · 2 comments

Comments

@AdamRJensen
Copy link
Contributor

I think it's quite unusual to include a folder with the licenses of dependencies.

One of the main reasons I'm against this is that it is a certainty that these licenses will be outdated. For example, the included pvlib license is no longer correct. pvlib does not do this, and given its affiliation with Sandia I do not think this is necessary here.

Perhaps @cwhanse can comment on this from a Sandia point of view?

@cwhanse
Copy link

cwhanse commented Sep 12, 2023

I agree with @AdamRJensen we don't need to include license text for packages that are imported. Importing a module is use of that module, not redistribution. If we include a copy of the source code for a package, then we would need to preserve the license text.

@AdamRJensen AdamRJensen changed the title [JOSS review] Consider removing external licenses in NOTICE folder [JOSS review] Remove external licenses in NOTICE folder Sep 13, 2023
@kbonney
Copy link
Collaborator

kbonney commented Oct 5, 2023

Addressed by #80. Resolution: deleted notice folder

@kbonney kbonney closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants