Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RB edesigns' truncate_to_available_data fails to truncate auxiliary information #408

Closed
jordanh6 opened this issue Mar 7, 2024 · 1 comment
Closed

RB edesigns' truncate_to_available_data fails to truncate auxiliary information #408

jordanh6 opened this issue Mar 7, 2024 · 1 comment
Assignees
@tjproct @jordanh6
Labels
bug A bug or regression
Milestone
0.9.12.3

Comments

@jordanh6
Copy link
Contributor

jordanh6 commented Mar 7, 2024

MirrorRBDesign.truncate_to_available_data truncates the the edesign's circuit_lists, but it does not truncate idealout_lists. This means that the mapping between circuits and target bit strings is lost.

Example notebook attached.

Expected behavior: Returned edesign should have idealout_lists that contain exactly the idealouts of the circuits remaining in the truncated design.

Based on skimming the code I suspect other RB protocol edesigns have an analogous issue.

Environment:

  • pyGSTi v0.9.12.1
  • python 3.8

edesign-truncate-bug.zip
@jordanh6 jordanh6 added the bug A bug or regression label Mar 7, 2024
@sserita sserita modified the milestones: 0.9.12.2, 0.9.13 Apr 2, 2024
@sserita sserita modified the milestones: 0.9.13, 0.9.12.3 May 14, 2024
sserita added a commit that referenced this issue May 21, 2024
@sserita
Fix #408.
6e3c345 
This derives truncation functions for ByDepthDesign and BenchmarkingDesign
such that paired list information (depths, circuits, idealouts)
are maintained through truncation.
sserita added a commit that referenced this issue May 21, 2024
@sserita
Updated fix for #408.
9d6339c 
Generalizes serialization/truncation for attributes
that are "paired" with the circuit lists in BenchmarkingDesigns.
This removes the code duplication in inherited classes
with more "paired" attributes,
such as CliffordRBDesign (with the new native gate info) and
BinaryRBDesign (with measurements/signs).
@sserita sserita mentioned this issue May 22, 2024
Merged
@sserita
Copy link
Contributor

sserita commented Jun 1, 2024

Closing as this is merged in develop with #443

@sserita sserita closed this as completed Jun 1, 2024
@sserita sserita added the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Jun 1, 2024
@sserita sserita removed the fixed-but-not-in-release-yet Bug has been fixed, but isn't in an official release yet (just exists on a development branch) label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjproct tjproct

@jordanh6 jordanh6

Labels
bug A bug or regression
Projects
None yet
Milestone
0.9.12.3
Development

No branches or pull requests
3 participants
@tjproct @jordanh6 @sserita