Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed commented-out function definitions #428

Open
rileyjmurray opened this issue Apr 24, 2024 · 2 comments
Open

Removed commented-out function definitions #428

rileyjmurray opened this issue Apr 24, 2024 · 2 comments
Milestone

Comments

@rileyjmurray
Copy link
Contributor

While on develop's latest commit I ran a search for "#def " and got 156 results in 82 files (excluding jupyter notebooks). This pattern just about always indicates that an entire function has been commented out. I suggest we remove these commented-out functions, with exceptions for specific functions as needed.

To implement this suggestion I'd just delete all the offending lines, open a new PR, and then get reviews from @sserita, @coreyostrove, and @enielse. How do folks feel about this?

@rileyjmurray rileyjmurray added bug A bug or regression and removed bug A bug or regression labels Apr 24, 2024
@sserita
Copy link
Contributor

sserita commented Apr 24, 2024

I'm generally for this type of clean-up. We'll just have to be extra careful on the review of that PR to make sure we're not removing something we want. Even if its not currently in use, there's a chance something could be reference that we want to keep or functionality that we want to get back to implementing in the future.

BTW, If you are doing this, can you take care of #424 at the same time?

@rileyjmurray
Copy link
Contributor Author

I'm all for being extra careful with the review. Yes, I'll include #424 in the PR when ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants