Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed login improvements #111

Open
neynah opened this issue Oct 14, 2016 · 3 comments
Open

Proposed login improvements #111

neynah opened this issue Oct 14, 2016 · 3 comments

Comments

@neynah
Copy link
Collaborator

neynah commented Oct 14, 2016

Currently users need to log in to the App Market to leave a review- even if they're already signed in to Oasis. Ideally they should not have to log in to the App Market again if they've already signed in to Oasis.

At the very least (as a half-measurement) we should enable email log in as currently we only have github & google log in options.

image

@kentonv
Copy link
Member

kentonv commented Oct 21, 2016

Arguably the app market should be a Sandstorm app running on Oasis via a standalone domain!

::ducks::

@paulproteus
Copy link
Collaborator

re: App Market as Oasis standalone domain app:

Important cons:

  • I guess the main showstopper right now is presumably SEO. We can maybe test this?

Other not-quite-as-important issues:

  • I'd personally want an automated deploy flow, which Sandstorm doesn't currently provide as a supported feature. However, I could probably hack it! I could write some automation that calls Meteor methods, which would work OK for me.
  • It would change our "who can deploy it?" answer from "Anyone with shell access to the app market machine" to "Just Asheesh" which I find to be a saddening change.

I might brainstorm other issues here.

@kentonv
Copy link
Member

kentonv commented Oct 28, 2016

I don't think it would actually work right now. Maybe it's not that far from working but probably not something to spend time on right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants